- Consolidate apk & apt commands
- Consolidate ENV layers
- Consolidate RUN layers
- Remove unused variables
- Remove packages that are no longer needed
- Bind mount /app/Pipfile
`/cache` is now a `tmpfs` mount that has a `cache` mount on top for `pipenv` to use.
`apt` has `cache` mounts in the standard places:
- /var/lib/apt
- /var/cache/apt
It's better to not have a rating than to create parsing problems.
An example of what is avoided:
```
<ratings>
<rating name="youtube" max="5" default="True">
<value>None</value>
<votes>16781</votes>
</rating>
</ratings>
```
This is only intended for use in containers, so we know where python3 should be installed.
This is called very often, so we should try to use as few resources as we can.
* Do without --link for COPY or ADD
* Do without --checksum for ADD
* Trim the FFMPEG_VERSION variable with cut instead
I've built successfully on old Debian systems using these changes. Everything else I use has a newer docker on it.
- Specify the syntax be the latest stable version and that failed checks should stop the build.
```
By default, builds with failing build checks exit with a zero status code despite warnings. To make the build fail on warnings, set #check=error=true.
```
- Use the form of health checking that doesn't involve an extra shell on every check.
* Create a s6-overlay-extracted stage to copy from
This was largely inspired by: @socheatsok78
Our downloaded files are checked where that version doesn't do any verification of the downloads.
* Update ffmpeg to the first build with checksums.sha256
* Create a ffmpeg-extracted stage to copy from
* Don't preserve ownership from the builder
I was sick of the extra work with ffmpeg builds.
So, I managed to get sums generated for those builds and now we don't need to manually fill out SHA256 hashes anymore.
Now to bump ffmpeg, we can just change the date.
Running the ffmpeg in an earlier (hopefully cached) layer should clean up the logs a bit.
On a related note, shadowing the environment variable was causing some confusing log output, so stop doing that as well.
The `automatic_captions` has a layer for language codes that I didn't account for.
The type checking was copied and I didn't adjust for the arguments in this function.
```
{key}: This video is available to this channel's members on level: Level 2: Contributor (or any higher level). Join this YouTube channel from your computer or Android app.
```
It's more directly what we want here.
If `filepath` ever changed to not use `filename` the value would be incorrect, so this is the cleaner way to display this value.
The `filepath` variable is defined before the `if` and used throughout the first block, so we should use it in the `else` block too.
Otherwise, a change to that variable would change the first block but not the second block.
`media.filename` is a `str`
`media.filepath` is a `Path`
The second has a simple way to remove directories, so use that instead of any custom string manipulation.
Python `3.13` is not expected to work until Django `5.1` and we are currently using `3.2`, so that's not worth testing.
More info: https://code.djangoproject.com/ticket/34900
tcely